chore: bump revm to 21.0.0 release
#10183
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
commented
Apr 24, 2025
Comment on lines
+324
to
+326
| // if let Some(factory) = &self.precompile_factory { | ||
| // inject_precompiles(&mut evm, factory.precompiles()); | ||
| // } |
There was a problem hiding this comment.
Possibly related: alloy-rs/evm#71
cc @yash-atreya
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Opening for visibility / easier collaboration
Restructured commit history so it is easier to revert to known good changes whilst iteratively implementing the complex changes (handler, journal)
Uses #10051 as reference
CI is expected to be failing for quite some time
Solution
Depends on:
Next steps:
foundry-evm-corecrate, preferring internal mapping types rather than direct replacement - similar to Ethers > Alloy migration processEvmContext/InnerEvmContextsuccessorinterpreter.shared_memorysuccessorInvestigate internal mapping approach rather than refactor cheatcodesalloy-evmto0.5.0CustomPrintTracerin Add equivalent of Revm v19CustomPrintTracerbluealloy/revm#2422Blocking
Currently is blocking:
cast): trace printer returns "broken" gas value around0x1precompile #10276 has been fixedforge bind): generated contract bindings are incompatible with alloy-rs0.14.0#10321Follow ups:
CustomPrintTracerto use Revm'sTracerEip3155#10329Issues:
with_evmcopiesl1_block_info, this field no longer exists yielding the question whether Cheatcodes, like Anvil, expectsOpEvmget_prankcheatcode expectsdepthto be au64, not ausize-try_into?worksccx.ecx.journaled_state.load_account(&mut ccx.ecx.db(), *from)causescannot borrowccx.ecxas mutable more than once at a time second mutable borrow occurs herePR Checklist